?
avatar ciar4n
ciar4n
7 Aug 2017

The main issue is that in most cases the 'Module Class Suffix is been echoed twice. With a couple of exceptions if you inspect a module in the frontend you will notice the class been echoed at a modChrome level and again inside the module itself.

In the following example Module Class Suffix = card-outline-danger

suffix

Personally I think the class should be moved to the outer container (eg. top-b) and removed from within the module.

avatar ciar4n ciar4n - open - 7 Aug 2017
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Aug 2017
Category com_modules
avatar C-Lodder
C-Lodder - comment - 8 Aug 2017

Does this online apply with Custom Modules?

Also, I believe you're targeting the modules in you CSS-grid script with the top-b (etc) classes aren't you?

avatar ciar4n
ciar4n - comment - 8 Aug 2017

Module suffix is been echoed in all modules except for mod_login and mod_wrapper. It is been echoed again in most module chromes with the exception I think of 'none'.

I added the position name as a class to each module with the CSS grid PR however it is currently not been used.

avatar ciar4n ciar4n - change - 8 Aug 2017
Title
[4.0] Module Class Suffix echo location
[4.0] Module Class Suffix echo'd twice
avatar ciar4n ciar4n - edited - 8 Aug 2017
avatar ciar4n
ciar4n - comment - 8 Aug 2017

PR created.. #17447

avatar ciar4n ciar4n - change - 8 Aug 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-08-08 18:39:29
Closed_By ciar4n
avatar ciar4n ciar4n - close - 8 Aug 2017

Add a Comment

Login with GitHub to post a comment