I am a bit confused - the search statistics for smartsearch aka finder are here in the toolbar

The Gather Search Statistics option in com_search are only for search and nothing to do with finder

IIRC we wired up Smart Search to log search queries the same way that regular search does.

The Smart Search statistics button is info on the actual search index data.

Ah - i see what you mean now

you are referring to logged search queries and not statistics

So it seems that it is simply a case of replicating the code for "searches" from com_search into com_finder?

Sorry for the confusion, yes I was referring to the logged search queries
(somewhat confusing in the terminology with statistics etc).

Ruth

On 7 August 2017 at 16:08, Brian Teeman notifications@github.com wrote:

you are referring to logged search queries and not statistics

So it seems that it is simply a case of replicating the code for
"searches" from com_search into com_finder?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17437 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACy3ofdU9E1s5SQKeV_aSmHPcxgrfaAAks5sVyhSgaJpZM4Ovi1q
.

--

Be like me, be Carbon free - don't print this and save a tree
IMPORTANT: The contents of this email and any attachments are confidential.
They are intended for the named recipient(s) only. If you have received
this email by mistake, please notify the sender immediately and do not
disclose the contents to anyone or make copies thereof.

I have looked into this and we actually have a problem with the storing of the search results

We are not logging which component the searches are coming from.

If you enable both search and finder and search logging then go to the link @RCheesley found for viewing the stats then they are all together AND the link to view the results will always open using search and not finder

So if a user was to enable logging in both places but only use finder on the frontend the search results will be displayed in both the current place and any new view I could create

I guess I could modify the code that saves to the database to include a flag to show if the search was from com_search or com_finder to resolve that. Then we can have two different search term analysis pages each one filtered for com_search or com_finder.

@mbabker @wilsonge thoughts on that idea

The component name is already available https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Helper/SearchHelper.php#L32 So I think it's just about storing it in the database. Given that it's a public library and any component theoretically can be passed in - it's probably worth storing the full component rather than just a flag (I'm thinking about the Dutch community doing their stuff on other open source search engines like elastic search - plus the stuff JED have talked about at times too)

yes i can do it that way with the component name.

Should this PR be targetted at 3 or 4?

I'm not sure. I mean are we planning on moving the view or just adding the extra column displaying the component?

My first thought was to move the view and then we only have one search menu item. The limitation them are

1. We would need an option to select the search component being used to display the search results
2. Where do you put the component options?

I would target this for 4.0 and then rename the (create a new) logging table and move the view to Finder/Smart Search. I would also remove com_search altogether. Can this issue be assigned to me, so that I don't forget?

@Hackwar we can only assign people who are part of the maintainers team - limitation of github :(

This is now fixed in #20681

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17437

closed as having Pull Request #20681