Feeling Lucky
?
?
[#17436] - Installation
- Fixed in Code Base
- 15 Aug 2017
- Medium
- Build: staging
- # 17436
- Diff
- brianteeman:installations2
- Success hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr this build is pending Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
As discussed with @mbabker we can permanently resolve the issue of the name of the installation folder from being translated by removing it from the string and inserting it dynamically using JText::sprintf
All other attempts have failed so this is the only way we can ensure that users are presented with the correct information
Updated PR to work around some guthub issue with #17276
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
Quy
- comment
- 8 Aug 2017
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17436.
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-15 11:56:05 |
| Closed_By | ⇒ | mbabker |
brianteeman
- comment
- 15 Aug 2017
Thanks for merging
zero-24
- comment
- 15 Aug 2017
why did we merge that with a red drone: http://213.160.72.75/joomla/joomla-cms/7860 ?
I'm going to prepare a PR..
mbabker
- comment
- 15 Aug 2017
Missed that, my bad.
For whatever reason it was still missing that file's changes here, I just fixed it. We should be good now.