[#17410] - [4.0] web components fixes
- Fixed in Code Base
- 5 Aug 2017
- Medium
- Build: 4.0-dev
- # 17410
- Diff
- dgt41:§4.0-dev-web-components-fixes
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #17376 .
Summary of Changes
- Fix the FOUC for ff
- Fix an infinite loop if the alert had no level defined
- remove the extra script for the loader, code is part of core.js (~140 lines)
- Add the non minified versions of the web components, for both the ES5 and ES6 scripts
- Also the non minified and the maps for the poly fills
Testing Instructions
Apply patch and test that alerts are still good for all the supported browsers
Expected result
Actual result
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Administration Templates (admin) Libraries Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item
After "Save" Article got:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17410.
@franz-wohlkoenig why is this unsuccessfully ?
@franz-wohlkoenig this is unrelated to what this PR is doing! If you think that this alert should be green (although the type is message not success) please open an issue.
To better understand what I am talking about check the title of your image with the next one:
| Category | JavaScript Repository Administration Templates (admin) Libraries Front End Templates (site) | ⇒ | JavaScript Repository Administration Templates (admin) Libraries Front End Templates (site) Unit Tests |
| Labels |
Added:
?
|
||
All seems to be working for me. One thing I'd suggest is setting a min width for the alert. The "Article saved" alert is just way too small.
Other than that, the alert needs to be green, not blue, but as you said, that's not related to this PR.
I have tested this item
As Colour is not related to this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17410.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-05 11:16:46 |
| Closed_By | ⇒ | wilsonge |
@C-Lodder can you test this one?