[#17364] - Use the renamed field in the TagsHelper
- Fixed in Code Base
- 14 Aug 2017
- Medium
- Build: staging
- # 17364
- Diff
- zero-24:tagsfix
User tests: Successful: Unsuccessful:
Pull Request for Issue #17363
Summary of Changes
In the query we rename the name to author. But later we use the old name which result in some cases to an SQL error.
Thanks @LivioCavallo
Testing Instructions
basicly review.
Expected result
use the renamed field name
Actual result
use the original field name
Documentation Changes Required
none
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I see that there is a check pending, commit cannot be built, there seems to be a conflict?
What can I do to solve this?
| Labels |
Added:
?
|
||
@LivioCavallo Sorry i had vacation until now. I have just fixed the merge conflict (as the files got moved again)
The only thing you can do to move this thing forward is to mark a successfull test unsing the issue tracker: https://issues.joomla.org/tracker/joomla-cms/17364 there you find after login via github this blue button:
There you can mark your test as successfull so a maintainer can merge this into 3.8.0
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks @LivioCavallo and @alikon
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17364.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-14 12:37:32 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 8797e5c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17364.