[#17218] - Frontend: com_content view review
- Closed
- 7 Nov 2017
- Medium
- Build: staging
- # 17218
- Diff
- zero-24:com_content
User tests: Successful: Unsuccessful:
Summary of Changes
Review frontend com_content views
Testing Instructions
Install sample testing data and navigate all the com_content frontend views.
Expected result
All still works
Actual result
The touched views have cs errors ;)
Documentation Changes Required
None
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
@zero-24 can you gic´ve Examples for each View what CodeStyle-Errors are shown without Pull Request?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17218.
| Status | Pending | ⇒ | Information Required |
I have tested this item
Test Views:
- Single Article
- Article Categories
- Article Category Blog
– Article Category List:
- Featured Articles
- Archived Articles
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17218.
@franz-wohlkoenig i have just merged staging into this PR. Please double check that.
Same Result: All Views works except /index.php/en/article-category-list
@franz-wohlkoenig please try with the last changes
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17218.
Closing as this is conflicting and this is going to be moved against 4.0-dev in a later PR. Thanks @Quy &@franz-wohlkoenig your comments they are not going to be missing. I'm going to implement as much as possible directly in the new PR. Thanks for all the work on the reviews
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-07 22:55:16 |
| Closed_By | ⇒ | zero-24 |
Thanks i have fixed the inline comments @Quy