[#17217] - Frontend: com_contact view review
- Closed
- 7 Nov 2017
- Medium
- Build: staging
- # 17217
- Diff
- zero-24:com_contact
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Summary of Changes
Review frontend com_contact views
Testing Instructions
Install sample testing data and navigate all the com_contact frontend views.
Expected result
All still works
Actual result
The views have cs errors ;)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Labels |
Added:
?
|
||
I have not tested this item.
No errors found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17217.
I have tested this item
No errors found
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17217.
@franz-wohlkoenig please explain what you want from me? I'm a bit lost with your comment? :(
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17217.
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17217.
Same here I'm closing this as it is conflicting and this is going to be moved against 4.0-dev in a later PR. Thanks @Quy , @franz-wohlkoenig , @Heggi93 & @brianteeman your comments they are not going to be missing. I'm going to implement as much as possible directly in the new PR. Thanks for all the work on the reviews
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-07 22:56:41 |
| Closed_By | ⇒ | zero-24 |
Thanks @brianteeman i have just fixed the comments.