Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17069] - [4.0] Add support to view typed password in input field

? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
11 Jul 2017

Summary of Changes

This PR adds a small icon/trigger to the password input fields, allowing you to view the password you've typed in. Make life much easier for those who use very long and complex passwords

Testing Instructions

  • Apply PR
  • Go to edit your profile in the backend or view the front-end login form
  • Type in your password, then click the "eye" icon to the right of the input

Notes:

  • This is part 1 of the password field on forms.
  • Part 2 will be removing any password confirmation fields from core as they won't be needed after this.
avatar C-Lodder C-Lodder - open - 11 Jul 2017
avatar C-Lodder C-Lodder - change - 11 Jul 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2017
Category ⇒ Layout JavaScript Modules Front End
avatar C-Lodder C-Lodder - change - 11 Jul 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 11 Jul 2017
avatar C-Lodder C-Lodder - change - 11 Jul 2017
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Jul 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

I have tested this item ? unsuccessfully on 69e8dc3

Test on "My Profile", Backend:
Password isn't shown in Field Password
Password is shown in Field Confirm Password

System information

4.0.0-dev
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17069.
avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

@franz-wohlkoenig seems fine for me.

screeny2

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

I have tested this item ✅ successfully on 69e8dc3

ReLogin, Browser-Cache cleared > works.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17069.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2017
Category Layout JavaScript Modules Front End ⇒ Modules Administration Layout JavaScript Front End
avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

@franz-wohlkoenig perfect, thanks :)

avatar wilsonge
wilsonge - comment - 11 Jul 2017

Need to fix travis

avatar brianteeman brianteeman - test_item - 11 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Jul 2017

I have tested this item ✅ successfully on f7044e8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17069.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2017
Category Layout JavaScript Modules Front End Administration ⇒ Modules Administration Layout JavaScript Front End Unit Tests
avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

@wilsonge unit tests updated

avatar wilsonge wilsonge - change - 11 Jul 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-07-11 14:57:14
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Jul 2017
avatar wilsonge wilsonge - merge - 11 Jul 2017

Add a Comment

Login with GitHub to post a comment