[#17002] - Language detection in snowball stem
- Closed
- 21 Apr 2019
- Medium
- Build: staging
- # 17002
- Diff
- StefanLindner:StefanLindner-patch-for-16981-stemmer-language-fix
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
As @chrisdavenport requested
Pull Request for Issue #16981 .
Test-Instructions (a little bit complicated)
- You need a second frontend language (german in this example)
- Make german the default language
- Configure finder to use stem and snowball
- Install snowball stem (standard php does not include snowball). For php 5.6 this can be done via pecl from https://github.com/marc-mabe/php-stem (for php 7 it must be done by hand)
- Have 2 different articles, place the words "Heiterkeit" in the first and "Heiterung" in the second one. Both have the stem "Heiter" in german
- Without this patch at least one of them does not have the stem "Heiter". You could check this by direct sql query "select * from ...finder_terms where term like 'heiter%'"
Please excuse the delay but I digged a bit deeper into joomla's finder component and the use of stems. See #17085 if interrested.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
@franz-wohlkoenig test instructions seem to be in place.
any news on this PR?
@chrisdavenport you agreed with the corresponding solution in issue #16981. could you have a look? thank you!
@franz-wohlkoenig OK. what does that mean?
All pull requests require tests from two individuals other than the person who created it to test and make sure that it fixes the reported issue without introducing other issues. Most pull requests that don't get merged are usually due to a lack of testing or interest.
@level420 if you wan't to test, please have a Look at this Article by Brian Teeman.
You would have to use FinderIndexerHelper::getPrimaryLanguage() to convert from the language code to the short code.
| Title |
|
||||||
Can we close this one? Staging does not accept new features at this stage and in 4.0 this has been completely rewritten, thus makeing this obsolete.
closed as stated above.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-21 15:40:31 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Removed:
J3 Issue
|
||
@StefanLindner can you please give Test Instructions in Comment above (how to test or code review)?