[#17001] - REGRESSION - Joomla 3.7.3: Reoccurence of profile form bug previously fixed in 3.7.0
- Closed
- 10 Jul 2017
- Medium
- Build: staging
- # 17001
Please refer to #13254
This pull request was made in response to a bug in J 3.6.5 whereby user profile fields would be displayed as optional on the registration form despite being set to disabled.
The fix involved changing $this->getForm(array(), false) to $this->getForm(array()).
This fix has been reverted in J 3.7.3 and the same bug is now happening again.
The reverted code also includes a comment "Don't load the data in this getForm call, or we'll call ourself", so clearly there is a reason for it to be written that way, but it is breaking the user profile plugin.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | com_users |
| Title |
|
||||||
@bembelimen
Please look what you can do as it seems your PR is at stake
#15724
| Status | New | ⇒ | Information Required |
I have this (old) problem:
Terms of Service article is not linked to TOS label
Your text to link here...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17001.
@funbugpiz looks like this Issue you reported isn't related to this issue so can you please open an new Issue?
Sorry, I think there is a realation. But I can be wrong.
If I changes in components/com_users/models/registration.php line 247:
$form = $this->getForm(array(), false); to
$form = $this->getForm(array()); See above, then I fix the problem with the TOS link.
Also look at: false param on fetching form data
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17001.
@infograf768 can you please have a look about Relation?
Results of my tests.
First :
User profile fields would be displayed as optional on the registration form despite being set to disabled.
I can't confirm that one when new registration in frontend :
Plugin params:
Registration form:
Address 1 and Address 2, which are disabled, do not display in the registration form, which is correct.
But Country, which is required, is set as Optional, which is incorrect
While creating a new User in back-end, that user profile form in back-end just does not take into account at all of Optional/Required params, behavior similar to Registration (screenshot below).
Editing a profile in frontend
Plugin params:
Frontend and back-end profile edit:
Disabled and Required fields are set OK.
Second:
Terms of Service article is not linked to TOS label
I confirm the error.
(NOTE: For a multingual site, the TOS article has to be tagged to the correct Content Language, and its category too. Associations are to be used with other TOS articles tagged to the other Content Languages, themselves in categories tagged to the same Content Language)
Indeed reverting
$form = $this->getForm(array(), false);
to
$form = $this->getForm(array());
Solves both issues.
| Title |
|
||||||
| Status | Information Required | ⇒ | Discussion |
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-10 06:04:36 |
| Closed_By | ⇒ | infograf768 |
Hi infograf768,
I'm relative new here.
_
Second: Terms of Service article is not linked to TOS label_
What is the following step(s) to solve this problem?
Gr.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17001.
@funbugpiz please have a Look at PR #17043
Additional: I was also about to post a second ticket, stating that the J 3.7.3 update had also broken another third party user plugin, the Multi Usergroup Registration plugin. However, it turns out that this is also caused by same change. I made the same fix as before; ie removing the
falseparameter; and the issues in both plugins were resolved.