Feeling Lucky
?
[#16995] - [CODE STYLE] Fixes javascript code style issues found by Hound
- Closed
- 20 Aug 2017
- Medium
- Build: staging
- # 16995
- Diff
- regularlabs:patch-2
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
This is just a cosmetic PR.
This fixes some javascript code style issues found by Hound as seen in this PR: #16947
It does not influence the final minified core.js file (the one that gets loaded), as the minifier already fixes these issues.
Only change in the minified core.js is the change of == to === when comparing to null.
Also, does not affect functionality.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
regularlabs
- comment
- 6 Jul 2017
You are free to test this in debug mode. :)
regularlabs
- comment
- 20 Aug 2017
Closing due to lack of interest.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-20 19:47:09 |
| Closed_By | ⇒ | regularlabs |
Dont forget the unminified js gets loaded (usually) when in debug mode