[#16991] - CodeMirror updated to v5.27.4
- Closed
- 21 Jul 2017
- Medium
- Build: staging
- # 16991
- Diff
- okonomiyaki3000:CodeMirror-Update
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
CodeMirror updated to latest version.
http://codemirror.net/doc/releases.html
Testing Instructions
Use CodeMirror.
Expected result
It should work just as the previous version.
Actual result
Yes it does.
Documentation Changes Required
Nope.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript External Library |
This Hound seems like a good boy but he need not check 3rd party libraries.
I don't know what this error is but it's surely wrong.
| Labels |
Added:
?
|
||
@okonomiyaki3000 - errors are valid points, but we're not using going to be linting JS on Joomla 3, only Joomla 4
Ah, well just ignore the comments by Hound, they hopefully won't happen on future PR's for staging ;)
Ah, now I remember, there was a Jenkins pr-merge error for some reason. Anyway, gone now so no problem.
That one was from the new Jenkins pipeline. It's still a little quirky but not a merge blocker so it's safe to ignore until we say otherwise
It's back.
I am going to close this as there now is a newer release
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-21 17:23:47 |
| Closed_By | ⇒ | brianteeman |
I don't believe there is much of particular interest to most Joomla users in this update.