[#16959] - Checked out filter field (new feature)
- Closed
- 11 Aug 2017
- Medium
- Build: master
- # 16959
Steps to reproduce the issue
We have command buttons 'Check-in' for lists of items (articles, contacts, categories etc.) at the admin panel, but we cannot filter checked out items.
I suggest to add that filter field (see the attached file) and add the key JOPTION_SELECT_CHECKED_OUT="- Select Checked out -" to the administrator/language/en-GB/en-GB.ini file. Then we can add tofilter_(...).xml files:
<field
name="checked_out"
type="checkedout"
dbtable="_TABLE_NAME_"
onchange="this.form.submit();"
>
<option value="">JOPTION_SELECT_CHECKED_OUT</option>
<option value="-1">JALL</option>
</field>
and to models files:
// Filter by checked_out
$checkedOut = $this->getState('filter.checked_out');
if (is_numeric($checkedOut))
{
$checkedOut = (int) $checkedOut;
$query->where('a.checked_out ' . (($checkedOut > 0) ? ' = ' . $checkedOut : ' > 0'));
}
Expected result
Actual result
System information (as much as possible)
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Category | ⇒ | com_content |
| Status | New | ⇒ | Discussion |
| Category | com_content | ⇒ | com_content Feature Request |
I'd say to libraries/cms/form/field since it is CMS specific.
You should be able to create files after you forked the repo. Then you work in your own instance of this repo and you have full access to do anything. Best to create a new branch first and then start doing your changes in that branch.
The trouble is that the folders /libraries/cms/form and /libraries/cms/form/field are missing in my fork. I suppose, that I don't have access to do PR in that folder.
That means your forked repo is not up-to-date and you need to revise it
I see this folders at my local installed copy of Joomla 3.7.4, but I don't see they at fork of staging branch.
yes - many files have been moved for the next release of Joomla
@brianteeman, well, I try next release.
Could you look at pr #17316? The trouble is that com_content and com_contact use the same layout for categories (/layouts/joomla/content/category_default.php), but .xml-files of com_contact don't contain appropriate option show_category_heading_title_text.
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-11 13:48:02 |
| Closed_By | ⇒ | nvyush |
Since you already propose some code, can you please create a Pull request?
See https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests