[#16958] - [com_fields] Fields are not copied when batch duplicating an article
- Fixed in Code Base
- 7 Feb 2018
- Medium
- Build: staging
- # 16958
- Diff
- thongredweb:16740
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16740
Summary of Changes
Add import plugin and run event for articles when do an batch copy or batch move to make sure these new article (Batch - copy) or changed articles (Batch - move) still have event stuff same as create / edit single article.
Testing Instructions
- Create 2 categories: "Category 1" and "Category 2"
- Create 2 fields: "Field 1" and "Field 2"
- Assign "Field 1" and "Field 2" for "Category 1"
- Assign "Field 1" for "Category 2"
- Create an "Article 1", assign for "Category 1", enter data for custom fields "Field 1" and "Field 2"
- Go to Articles Management page, check for select "Article 1" in list, press button "Batch", choose "Category 2", choose "Copy" and press "Process"
- Go to Articles Management page, check for select "Article 1" in list, press button "Batch", choose "Category 2", choose "Move" and press "Process"
Expected result
- For "Batch - Copy" process, new "Article 1" has been created in "Category 2". Custom field data for "Field 1" was copied too.
- For "Batch - Move" process, "Article 1" has been assigned to "Category 2". Custom field data for "Field 1" still stay with this article.
Actual result
- For "Batch - Copy" process, Custom fields data has been gone.
- For "Batch - Move" process, Custom fields data has been gone.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
@mbabker its to early for Test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16958.
This actually really needs to be done in a spot where it would automatically pick it up if an extension supports fields in general (so every extension doesn't have to duplicate this logic).
--> Because store fields data is handled via plugin system, so if any extension supports fields in general they have to import plugin group system and trigger event onContentAfterSave for each object data implement fields.
Actually batch loop is an list of single object for create / edit. They have to be trigger event in each of them as single article.
| Labels |
Added:
?
|
||
Perhaps we should consider to introduce a new batch event which sends all articles in one event, instead of one event per article.
@laoneo I don't think that is good idea. If we add new event for batch of articles, the scope of progress will not correct for other extensions. Let say if I write event on Article save, I need to write another block code for batch of articles. Code duplicated with exactly do the same.
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16958.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16958.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-07 00:27:17 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Merged based on the tests above
This actually really needs to be done in a spot where it would automatically pick it up if an extension supports fields in general (so every extension doesn't have to duplicate this logic).
Adding
onContentAfterSaveto the batch loop also needs to be thoroughly tested.