? Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
1 Jul 2017

Pull Request for Issue #14667

Summary of Changes

The view used the wrong parameter value so the tag description wasn't truncated

Testing Instructions

See #14667 and #16844

  • Create a menu item of type "List of all tags."
  • From the Options tab while defining this menu item set the "Maximum characters" (under description) to 200 (presumably any number).

Before Patch

The full description is always displayed regardless of what value is used to truncate it.

After Patch

The tag description is truncated at 200 characters according to the menu options above when selecting the menu item above for display.

Documentation Changes Required

none

avatar rdeutz rdeutz - open - 1 Jul 2017
avatar rdeutz rdeutz - change - 1 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2017
Category com_tags Front End
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jul 2017

I have tested this item successfully on e2a9718


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16929.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Jul 2017

@rdeutz didn't get relationship of #16844 to this PR.

avatar rdeutz
rdeutz - comment - 1 Jul 2017

ups wrong number I meant #16248

avatar Quy Quy - test_item - 3 Jul 2017 - Tested successfully
avatar Quy
Quy - comment - 3 Jul 2017

I have tested this item successfully on e2a9718


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16929.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jul 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jul 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 5 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-05 15:53:02
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Jul 2017
avatar mbabker mbabker - merge - 5 Jul 2017

Add a Comment

Login with GitHub to post a comment