? Success

User tests: Successful: Unsuccessful:

avatar asika32764
asika32764
1 Jul 2017

Just a simple fix for admin mod_menu gorup in ONLY_FULL_GROUP_BY mode.

Testing Instructions

Force enable ONLY_FULL_GROUP_BY mode. You can use this code in pdomysql:

$this->connection->query("SET @@SESSION.sql_mode = 'STRICT_TRANS_TABLES,ONLY_FULL_GROUP_BY';");

Now admin panel will show this error, and the menu options all disappeared.

p-2017-07-01-001

After this PR, all menutypes will back:

p-2017-07-01-002

avatar asika32764 asika32764 - open - 1 Jul 2017
avatar asika32764 asika32764 - change - 1 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2017
Category Modules Administration
avatar asika32764 asika32764 - change - 1 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2017
Category Modules Administration Administration com_fields Modules
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2017
Category Modules Administration com_fields Modules Administration
avatar alikon alikon - test_item - 2 Jul 2017 - Tested successfully
avatar alikon
alikon - comment - 2 Jul 2017

I have tested this item successfully on 32c446b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16928.

avatar csthomas
csthomas - comment - 3 Jul 2017

This changes are OK but I propose #14011

avatar asika32764
asika32764 - comment - 3 Jul 2017

That will be better if we can get rid of too many groups.

avatar alikon
alikon - comment - 3 Jul 2017

missed that one

avatar alikon
alikon - comment - 6 Jul 2017

this can be closed cause #14011 is merged now

avatar asika32764
asika32764 - comment - 6 Jul 2017

:+1

avatar asika32764 asika32764 - change - 6 Jul 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-07-06 11:31:22
Closed_By asika32764
avatar asika32764 asika32764 - close - 6 Jul 2017

Add a Comment

Login with GitHub to post a comment