Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16909] - [4.0] Extend removal of component sidebar

? Success

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
29 Jun 2017

Pull Request for Issue # .

Summary of Changes

This PR extends the removal of the component sidebar menu to all components where the component menu matches the main navigation sub menu (see #16386) .

Applies to the following...

  • com_checkin
  • com_cache
  • com_cache&view=purge
  • com_users&view=users
  • com_users&view=groups
  • com_users&view=levels
  • com_users&view=notes
  • com_menus&view=items
  • com_banners
  • com_banners&view=clients
  • com_banners&view=tracks
  • com_newsfeeds
  • com_installer
  • com_installer&view=update
  • com_installer&view=manage
  • com_installer&view=discover
  • com_installer&view=database
  • com_installer&view=warnings
  • com_installer&view=languages
  • com_installer&view=updatesites
  • com_templates&view=styles
  • com_templates&view=templates
  • com_languages&view=installed
  • com_languages&view=languages
  • com_languages&view=overrides (Removed menu however still sidebar containing filter)

Excludes the following...

  • com_contact
  • com_finder

Components excluded contain items in the component menu not present in the main menu.

Testing Instructions

Apply patch and ensure the sidebar is removed and table is displaying correctly (full width) at each of the following or navigate through all list views ensuring the component menu is removed where applicable (see #16386)....

/index.php?option=com_checkin
/index.php?option=com_cache
/index.php?option=com_cache&view=purge
/index.php?option=com_users&view=users
/index.php?option=com_users&view=groups
/index.php?option=com_users&view=levels
/index.php?option=com_users&view=notes
/index.php?option=com_menus&view=items
/index.php?option=com_banners
/index.php?option=com_banners&view=clients
/index.php?option=com_banners&view=tracks
/index.php?option=com_newsfeeds
/index.php?option=com_installer
/index.php?option=com_installer&view=update
/index.php?option=com_installer&view=manage
/index.php?option=com_installer&view=discover
/index.php?option=com_installer&view=database
/index.php?option=com_installer&view=warnings
/index.php?option=com_installer&view=languages
/index.php?option=com_installer&view=updatesites
/index.php?option=com_templates&view=styles
/index.php?option=com_templates&view=templates
/index.php?option=com_languages&view=installed
/index.php?option=com_languages&view=languages
/index.php?option=com_languages&view=overrides (Removed menu however still sidebar containing filter)

Documentation Changes Required

Yes

avatar ciar4n ciar4n - open - 29 Jun 2017
avatar ciar4n ciar4n - change - 29 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Category ⇒ Administration com_banners com_contact com_content com_installer com_languages com_menus com_newsfeeds com_templates com_users
avatar ciar4n ciar4n - change - 29 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 29 Jun 2017
avatar ciar4n
ciar4n - comment - 29 Jun 2017

This leaves a bunch of redundant translation strings so a language change label would probably be appropriate.

avatar wilsonge
wilsonge - comment - 29 Jun 2017

Given that this is J4 can you just remove the strings please?

avatar Bakual
Bakual - comment - 29 Jun 2017

@ciar4n The label is added automatically as soon as you change something in a language folder.

avatar ciar4n ciar4n - change - 29 Jun 2017
Labels Added: ?
avatar ciar4n
ciar4n - comment - 29 Jun 2017

Related language strings removed

avatar ciar4n ciar4n - change - 29 Jun 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 29 Jun 2017

Looks like the Language Change label is not added automatically.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Category Administration com_banners com_contact com_content com_installer com_languages com_menus com_newsfeeds com_templates com_users ⇒ Administration com_banners com_cache com_checkin com_contact com_content com_installer com_languages com_menus com_newsfeeds com_templates
avatar ciar4n
ciar4n - comment - 29 Jun 2017

Included com_cache and com_checkin

@infograf768 Looks like the label is been removed with every commit. Hopefully that's the last one :)

avatar ciar4n ciar4n - change - 29 Jun 2017
The description was changed
avatar ciar4n ciar4n - edited - 29 Jun 2017
avatar Bakual
Bakual - comment - 29 Jun 2017

@mbabker Do you know why the label gets removed again by the bot? Does the script only work on staging?

avatar zero-24
zero-24 - comment - 29 Jun 2017

Please use if endif constuctes in PHP layout files and not if {} ;)

So basicly

<?php if (condition) : ?>
.... Your code ....
<?php endif; ?>
avatar zero-24
zero-24 - comment - 29 Jun 2017

Hmm looks like github removed my codeexample :( i'm currently on phone but i can add the example if needed from my PC when I'm back there.

avatar ciar4n ciar4n - change - 29 Jun 2017
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Category Administration com_banners com_contact com_content com_installer com_languages com_menus com_newsfeeds com_templates com_cache com_checkin ⇒ Administration com_banners com_cache com_checkin com_contact com_content com_installer com_languages com_menus com_newsfeeds
avatar ciar4n
ciar4n - comment - 29 Jun 2017

@zero-24 Like so?...

<?php if (!empty($this->sidebar)) : ?>
<div id="j-sidebar-container" class="col-md-2">
	<?php echo $this->sidebar; ?>
</div>
<?php endif; ?>
avatar Bakual
Bakual - comment - 29 Jun 2017

@zero-24 Fixed it for you ?
@ciar4n Yes

avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Category Administration com_banners com_contact com_content com_installer com_languages com_menus com_newsfeeds com_cache com_checkin ⇒ Administration com_banners com_cache com_categories com_checkin com_contact com_content com_fields com_installer com_languages
avatar ciar4n
ciar4n - comment - 29 Jun 2017

@zero-24 @Bakual Thank you. Done.

avatar zero-24
zero-24 - comment - 29 Jun 2017

Thanks :)

avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar sanderpotjer
sanderpotjer - comment - 5 May 2019

@wilsonge this issue can be closed. Most sidebars are removed meanwhile via other PRs. The only one left form the list mentioned in this issue is com_languages, but we have a PR for that: #24774

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 May 2019

closed as stated above.

avatar franz-wohlkoenig franz-wohlkoenig - close - 5 May 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 May 2019
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-05-05 13:28:54
Closed_By ⇒ franz-wohlkoenig
Labels Removed: J4 Issue

Add a Comment

Login with GitHub to post a comment