Feeling Lucky
?
?
[#16867] - Skip crypto cipher tests if operation cannot be performed
- Fixed in Code Base
- 26 Jun 2017
- Medium
- Build: staging
- # 16867
- Diff
- mbabker:skip-crypto-tests
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Summary of Changes
The version of the crypto library that we ship has an internal dependency to mcrypt. When running on PHP 7.2, this library can't be used safely and the test build (see https://travis-ci.org/joomla/joomla-cms/jobs/236743260 for example output) fails.
This PR adds a catch for the Exception that gets thrown when the library can't run due to missing dependencies in the test class so the class will skip the tests if the dependencies aren't met.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-26 10:26:51 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
|
||
Thanks