[#16866] - Don’t set page number
- Fixed in Code Base
- 26 Jun 2017
- Medium
- Build: staging
- # 16866
- Diff
- rdeutz:fix_16858
User tests: Successful: Unsuccessful:
Pull Request for Issue #16858.
Summary of Changes
We don't need to set the page number
Testing Instructions
- install 3.7.3-dev
- set up a
news flashmodule to the categoryJoomla!(using sample data)
Expected Result
No errors.
Actual result:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
works good here.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16866.
RocketTheme plugins commonly make the $page parameter a required argument which causes all sorts of excessive bug reports when you have an extension which does not include the parameter in the event arguments.
| Labels |
Added:
?
?
|
||
RocketTheme plugins commonly make the $page parameter a required argument which causes all sorts of excessive bug reports when you have an extension which does not include the parameter in the event arguments.
I'm not question anything anymore... Just "fixed" in the PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16866.
I have tested this item
@zero-24 its also documented as limitstart here https://docs.joomla.org/Plugin/Events/Content, so I guess it is not bad to send all of them
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16866.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-26 09:32:12 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
Removed: ? |
||
Thanks.
Should you not send at least 0 as page attribute?