Feeling Lucky
?
?
[#16861] - [4.0] Add error page for Atum
- Fixed in Code Base
- 28 Jun 2017
- Medium
- Build: 4.0-dev
- Easy Test
- # 16861
- Diff
- C-Lodder:error-page
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16836
Summary of Changes
Adds an error page to the Atum template
Testing Instructions
- Apply patch
- Navigate to
/administrator/index.php?option=com_blabla
Expected result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
C-Lodder
- comment
- 25 Jun 2017
@franz-wohlkoenig Only 1 file has been added.
So:
- Create an
error.phpfile - Add the code from https://github.com/C-Lodder/joomla-cms/blob/bdda52d1f2931536f165c5d5f60b5e50d5b2a315/administrator/templates/atum/error.php
- Place the file in
administrator/templates/atum/
franz-wohlkoenig
- comment
- 26 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16861.
andrepereiradasilva
- comment
- 26 Jun 2017
works fine, did notice some details tough:
- it's missing the joomla favicon.
- it's missing and html tag title
| Labels |
Added:
?
|
||
C-Lodder
- comment
- 26 Jun 2017
@andrepereiradasilva - Good spot. Added the title and favicon (d1f70d5)
andrepereiradasilva
- comment
- 26 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16861.
franz-wohlkoenig
- comment
- 26 Jun 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16861.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
franz-wohlkoenig
- comment
- 26 Jun 2017
RTC after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-28 20:55:23 |
| Closed_By | ⇒ | wilsonge |
cannot test caus joomla-extensions/patchtester#200