? ? Success

User tests: Successful: Unsuccessful:

avatar sshcli
sshcli
22 Jun 2017

Pull Request for Issue # .

Summary of Changes

Update some update.joomla URLs that were using the old http version.
Now they are https.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar sshcli sshcli - open - 22 Jun 2017
avatar sshcli sshcli - change - 22 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2017
Category SQL Administration com_admin Postgresql MS SQL Unit Tests
avatar sshcli
sshcli - comment - 22 Jun 2017

I have excluded this file:
tests\unit\schema\sqlsrv.sql

Please let me know if it is OK to change the URL here too.

avatar sshcli
sshcli - comment - 22 Jun 2017

What do you suggest?

avatar zero-24 zero-24 - change - 22 Jun 2017
Milestone Added:
avatar zero-24
zero-24 - comment - 22 Jun 2017

@sshcli you can also change that in that file. Why do you want to exclude that file?

Surely these old sql files do not need changes as the url will already be fixed by later sql?

Yes but is there something bad that this is now fixed earlier?

avatar brianteeman
brianteeman - comment - 22 Jun 2017

Nothing bad just pointless

avatar sshcli sshcli - change - 22 Jun 2017
Labels Added: ? ?
avatar sshcli
sshcli - comment - 22 Jun 2017

you can also change that in that file.

Done.

Why do you want to exclude that file?

Nothing wrong with the file.
I'm just trying to do a simple pr, not too complex for read by reviewers.
I'm trying to avoid any excuse for close this pr.
I hope you understand.

avatar sshcli
sshcli - comment - 22 Jun 2017

Thanks @zero-24

avatar tonypartridge tonypartridge - test_item - 29 Jun 2017 - Tested successfully
avatar tonypartridge
tonypartridge - comment - 29 Jun 2017

I have tested this item successfully on 197e0a5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16817.

avatar rdeutz rdeutz - change - 11 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-11 13:59:50
Closed_By rdeutz
avatar rdeutz rdeutz - close - 11 Jul 2017
avatar rdeutz rdeutz - merge - 11 Jul 2017

Add a Comment

Login with GitHub to post a comment