Feeling Lucky
?
?
[#16808] - [4.0] Javascript tests -drop node-modules directory
- Fixed in Code Base
- 3 Jul 2017
- Medium
- Build: 4.0-dev
- # 16808
- Diff
- dgt41:###############4.0-dev-js-tests
- Success hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Right now joomla is creating 3 instances of node-modules (root, javascript tests and media manager)
This PR is just dropping the /tests/javascript/node-modules in favour of the root node-modules (reducing the total disk space needed in a dev environment by few hundred MBs)
A script command is also available for the test:
npm run javascript-tests
Testing Instructions
apply the patch, run npm install in the root folder and then npm run javascript-tests
Javascript tests run as usual
Documentation Changes Required
We need to update the docs about javascript testing
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Labels |
Added:
?
?
|
||
| Category | JavaScript Unit Tests | ⇒ | Unit Tests Repository JavaScript |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-03 10:53:04 |
| Closed_By | ⇒ | wilsonge |
@zero-24 can you restart drone here?