Feeling Lucky
[#16803] - Update some apache links
- Closed
- 22 Jun 2017
- Medium
- Build: staging
- # 16803
- Diff
- sshcli:PR1
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Update some Apache links that were using the old http version of the url.
Now they are https.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository JavaScript |
franz-wohlkoenig
- | Status | Pending | ⇒ | Information Required |
rdeutz
- comment
- 22 Jun 2017
I don't see the value in this change
brianteeman
- comment
- 22 Jun 2017
closed for the reasons stated above
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-22 06:37:28 |
| Closed_By | ⇒ | brianteeman |
sshcli
- comment
- 22 Jun 2017
A question,
if I do a PR for update http://update.joomla.org to https://update.joomla.org
It will be closed too ?
zero-24
- comment
- 22 Jun 2017
if I do a PR for update http://update.joomla.org to https://update.joomla.org
It will be closed too ?
No you can do that (for the operational code this is already done looks like some unit tests needs to be updated and old update scripts.)
But please exclude the path JRoot\libraries\fof* as this is 3rd Party code.
As a general rule we don't change files from upstream providers. @rdeutz your call