? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
21 Jun 2017

Currently, com_associations can't handle categories with sections (eg extension=com_sermonspeaker.sermons). This was actually to a degree expected limitation of the component when it was merged. The thing was that we had no extension to try it.
That is also the reason this PR is targeted for J4, because I doubt it will ever get tested in J3 due to the lack of an extension which would use it (my SermonSpeaker 6 only installs in J4).

Summary of Changes

This PR adds support for such categories to com_associations in J4.

Testing Instructions

In the "Multilingual Associations" component

  • test that you can still associate regular categories (eg from com_content) and items as before. Nothing should change.
  • test with an extension that uses categories with sections that you can associate them. You can use my SermonSpeaker version here (or another one, if you know one):
    com_sermonspeaker.zip

Expected result

Can select and edit categories with sections

Actual result

Categories with sections can't be selected.

Documentation Changes Required

None

avatar Bakual Bakual - open - 21 Jun 2017
avatar Bakual Bakual - change - 21 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2017
Category Administration com_associations
avatar wilsonge wilsonge - change - 22 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-22 13:11:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 22 Jun 2017
avatar wilsonge wilsonge - merge - 22 Jun 2017
avatar wilsonge
wilsonge - comment - 22 Jun 2017

Thankyou!

avatar dgt41
dgt41 - comment - 22 Jun 2017

Can we fix CS:

FILE: ...la-cms/administrator/components/com_associations/Model/Associations.php
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
359 | ERROR | Space before opening parenthesis of function call prohibited

avatar wilsonge
wilsonge - comment - 22 Jun 2017

Done with 526db6b

avatar Bakual
Bakual - comment - 22 Jun 2017

I blame PhpStorm for not catching that ?

Add a Comment

Login with GitHub to post a comment