Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16796] - [4.0] Fixing Travis

? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
21 Jun 2017

Fixing Travis error introduced by #16779

Some tests did also have "expected" and "actual" inverted. I've switched those.

I don't understand why JToolbarButtonConfirmTest::testFetchButton has the id id="toolbar-", looks like it is missing a part there. But Travis should (hopefully) pass again.

avatar Bakual Bakual - open - 21 Jun 2017
avatar Bakual Bakual - change - 21 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2017
Category ⇒ Unit Tests
avatar Bakual Bakual - change - 21 Jun 2017
Title
…
Fixing Travis
[4.0] Fixing Travis
avatar Bakual Bakual - edited - 21 Jun 2017
avatar Bakual Bakual - change - 21 Jun 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jun 2017
Category Unit Tests ⇒ Layout Unit Tests
avatar Bakual
Bakual - comment - 21 Jun 2017

Removing the doubled space from the JLayout. Waiting for Travis to see if that fixes all of the issues 😄

avatar Bakual
Bakual - comment - 21 Jun 2017

@wilsonge Travis passes now. But it became a bit more than just unit tests. The layouts generated a doubled space since $id already contains the space (" id=foo")

avatar wilsonge wilsonge - change - 21 Jun 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-06-21 13:47:33
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 21 Jun 2017
avatar wilsonge wilsonge - merge - 21 Jun 2017

Add a Comment

Login with GitHub to post a comment