[#16794] - Calendar Fixes
- Fixed in Code Base
- 21 Jun 2017
- Medium
- Build: staging
- # 16794
- Diff
- dgt41:#######CAL_PERSIAN
User tests: Successful: Unsuccessful:
Pull Request for Issue #16590 .
Summary of Changes
List of changes:
- Make all comparisons strict
- fix the bottom buttons (clear, today, close)
- Clear button disappeared if today button was disabled
- Fix the inconsistency of manual input (enter, tab, etc)
Testing Instructions
Create a new article and fill the publishing fields with different methods (manual using the UI)
save the article
Edit again the fields (try clearing the filed with backspace, the clear button) and also change the values manually and using the UI
Report any remaining inconsistencies, if any
Expected result
Consistent behaviour
Actual result
Inconsistent behaviour
Documentation Changes Required
Calling @farhadst to crash test the Jallali calendar
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
| Category | JavaScript | ⇒ | JavaScript Unit Tests |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16794.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 18:55:25 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
@farzadtaheri @farhadst can you please test Joomla 3.7.3 RC! This is really important, thank you
PS you can get the installable here: https://github.com/joomla/joomla-cms/releases/tag/3.7.3-rc1
@farzadtaheri your solution Joomla.submitform('field.storeform', element.form); needs to be merged, can you do a PR for that?
my solution Joomla.submitform('field.storeform', element.form); is work, but there is another problem after this change!
calendar fields time shift after each category field value change, when i set Asia/Tehran time zone (or another time zones) in configuration!
please see this issue #16665
time and date reset to today.
- What was your input?
- If what you entered was invalid the calendar falls back to today!
Equivalent in en-GB
@farzadtaheri @farhadst Please test #16922 urgently
Some of these issues may be related to #17171. I made some changes that fix those issues ( #17183 ) but it involves removing a conditional that I don't fully understand the purpose of (that conditional was added in this pull request).
@dgt41, could you weight in on the the purpose of the if (typeof calObj.dateClicked === 'undefined') { conditional and why the false path is needed?
Originally, instead of removing it, I changed it to if (typeof calObj.dateClicked === 'undefined' || !calObj.dateClicked) { which fixed it for all cases except when using the "today" button (which results in calObj.dateClicked = true causing the else path to be taken).
Please @farzadtaheri also test this in Persian