Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16791] - Fix html5 validation, handle "novalidate" attribute correctly.

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
20 Jun 2017

Summary of Changes

Fix html5 validation, handle "novalidate" attribute correctly.

Testing Instructions

Open the form for create a new Article.
In the browser Developer console run next code:

  1. Imitate "Validation enabled":
Joomla.submitform('article.apply', document.getElementById('item-form'), true);
  1. Imitate "Validation disabled":
Joomla.submitform('article.apply', document.getElementById('item-form'), false);

Expected result

  1. No form submission. You should get native browser validation popup message "Fill this field" (near field) (or similar)
  2. Form submitted

Actual result

  1. Form submitted.
  2. Form submitted.

Documentation Changes Required

none

avatar Fedik Fedik - open - 20 Jun 2017
avatar Fedik Fedik - change - 20 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2017
Category ⇒ JavaScript
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

applied PR, got in new and empty Article:
bildschirmfoto 2017-06-20 um 18 33 30

System information

3.7.3-dev (latest nightly build)
Multilanguage Site
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar Fedik
Fedik - comment - 20 Jun 2017

@franz-wohlkoenig what is on your screenshot it is normal ?

need to look at different thing, see "Expected result"

avatar Fedik Fedik - change - 20 Jun 2017
The description was changed
avatar Fedik Fedik - edited - 20 Jun 2017
avatar Fedik Fedik - change - 20 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2017
Category JavaScript ⇒ JavaScript Unit Tests
avatar Fedik Fedik - change - 20 Jun 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

Using Joomla.submitform('article.apply', document.getElementById('item-form'), true); "Fill this Field" is shown.

Using Joomla.submitform('article.apply', document.getElementById('item-form'), false); got "Warning_ Field required: Title", which is expected. So a successsfully Test?

avatar Fedik
Fedik - comment - 20 Jun 2017

@franz-wohlkoenig yes, that is correct ?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jun 2017

I have tested this item ✅ successfully on 325ae01

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16791.

avatar Quy Quy - test_item - 20 Jun 2017 - Tested successfully
avatar Quy
Quy - comment - 20 Jun 2017

I have tested this item ✅ successfully on 325ae01

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16791.

avatar dgt41 dgt41 - change - 20 Jun 2017
Status Pending ⇒ Ready to Commit
Labels
avatar dgt41
dgt41 - comment - 20 Jun 2017

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16791.

avatar rdeutz rdeutz - change - 21 Jun 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-06-21 18:23:18
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 21 Jun 2017
avatar rdeutz rdeutz - merge - 21 Jun 2017

Add a Comment

Login with GitHub to post a comment