Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16785] - [4.0] Declare var "target" in modal-associations.js

? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Jun 2017

Summary of Changes

This is a very simple change. PhpStorm complained that the variable "target" is undefined and I just put the var before it so it is properly defined.

Testing Instructions

Review by a JS guru like @dgt41 should be enough.

avatar Bakual Bakual - open - 20 Jun 2017
avatar Bakual Bakual - change - 20 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jun 2017
Category ⇒ JavaScript
avatar C-Lodder
C-Lodder - comment - 20 Jun 2017

Please change this:

var target = document.getElementById('target-association');
document.getElementById('target-association').src = target.getAttribute('data-editurl') + '&task=' + target.getAttribute('data-item') + '.edit' + '&id=' + id;

to:

var target = document.getElementById('target-association');

if (target)
{
    target.src = target.getAttribute('data-editurl') + '&task=' + target.getAttribute('data-item') + '.edit' + '&id=' + id;
}
avatar Bakual Bakual - change - 20 Jun 2017
Labels Added: ?
avatar Bakual
Bakual - comment - 20 Jun 2017

Done

avatar wilsonge wilsonge - change - 20 Jun 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-06-20 12:31:27
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 20 Jun 2017
avatar wilsonge wilsonge - merge - 20 Jun 2017

Add a Comment

Login with GitHub to post a comment