? ?

Failure

User tests: Successful: Unsuccessful:

avatar coolcat-creations
coolcat-creations
18 Jun 2017

This PR replaces #8579 due to merge conflicts.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar coolcat-creations coolcat-creations - open - 18 Jun 2017
avatar coolcat-creations coolcat-creations - change - 18 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2017
Category Administration Language & Strings Front End com_content
avatar brianteeman brianteeman - change - 18 Jun 2017
Labels Added: ? ?
avatar Sieger66 Sieger66 - test_item - 27 Jun 2017 - Tested unsuccessfully
avatar Sieger66
Sieger66 - comment - 27 Jun 2017

I have tested this item 🔴 unsuccessfully on df67000

Make a article-category-list-menuitem.
Make an override in the Template Protostar for example: /html/com_content/article/my-66-override.php
Select this override in this article-category-list-menuitem -> List Layouts -> Alternative Layouts for Article
and save it.
I see in the frontend no override of a the article-view if i click on a article of the article-category-list of this menuitem.

Also the same, if you additional save in the article-category-list-menuitem -> Details -> Template Style -> protostar - default


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16755.

avatar shamsbd71
shamsbd71 - comment - 29 Jun 2017

I have tested this item successfully on df67000

@coolcat-creations can you apply the same xml code on archive category featured and categories. As all of theme are listing page and has a article details links on it.

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16755.

avatar shamsbd71 shamsbd71 - test_item - 29 Jun 2017 - Tested successfully
avatar Sieger66
Sieger66 - comment - 29 Jun 2017

The override works only if you use a default name for the override.

For example two overides in Protostar with the same content in the override-file:

This override works:
/html/com_content/article/default.php
But it works not always as expected !

This override dont work:
/html/com_content/article/my-66-override.php


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16755.

avatar brianteeman
brianteeman - comment - 29 Jun 2017

But it works not always as expected !

Please explain further

avatar coolcat-creations
coolcat-creations - comment - 29 Jun 2017

@Sieger66 please make a difference between overriding the default.php (Override) and providing a alternate Layout (giving the thing another name and select it in backend). Also please be sure that you use a clean site structure for testing and don´t use different overrides for the same duplicated blog category / article / whatever.

avatar Sieger66
Sieger66 - comment - 29 Jun 2017

Not always as expected is similar as in my post in #8579 ; 15.8.2016

article-category-list-menuitem -> Details -> Template Style
change to an other Template(for example Beez) and save it.

Then works the override with the Protostar-Template furthermore.
But you dont see this in the menu-item at:
article-category-list-menuitem -> List Layouts -> Alternative Layout for Article

avatar Sieger66
Sieger66 - comment - 29 Jun 2017

for the same duplicated blog category / article / whatever.

Yes i have found a article-category-list-menuitem in a other menu with the same category.
After i change the menueitem to a other category
i can see my alternative Layout-override "my-66-override.php" as expected.

But if i change in the menu-item to an other TemplateStyle(for example Beez)
article-category-list-menuitem -> Details -> Template Style
change to an other Template(for example Beez) and save it.

Then works the alternative Layout-override furthermore.
But you dont see this in the menu-item at:
article-category-list-menuitem -> List Layouts -> Alternative Layout for Article

If you now go to the article-category-list-menuitem -> List Layouts -> Alternative Layout for Article
and change this to "From Component -> default" and save it then is come the expected result(view without the override from the other Template). Or save it twice after change to an other Template Style.

avatar shamsbd71
shamsbd71 - comment - 30 Jun 2017

@Sieger66
I have tested as you asked and yes there is an issue but its not related to this xml params. its relate to
filed type componentlayout. we can create a new pull request to correct that. but for now its fine as it works with params as expected.

It Works

avatar Sieger66
Sieger66 - comment - 30 Jun 2017

alternative article layout override from category is a new feature and i dont now if we should RTC with this known bug ?

If RTC this new feature with the bug, then needs additional "documentation" or "warning" or not ?
I dont know that.

avatar mbabker
mbabker - comment - 30 Jun 2017

alternative article layout override from category is a new feature and i dont now if we should RTC with this known bug ?

It uses the same underlying form field as the other component based layout overrides do (and inherently the same underlying PHP API to handle that value). That layout parameter should save with a value like "template_name:layout_name" when saved to the database, and when used in the PHP API, that template name segment gets parsed by the view class to figure out that it needs to change the active template.

If that logic is broken, it will be a bug that already exists and would need to be addressed separately from adding this field.

avatar Webdongle Webdongle - test_item - 30 Jun 2017 - Tested unsuccessfully
avatar Webdongle
Webdongle - comment - 30 Jun 2017

I have tested this item 🔴 unsuccessfully on df67000

The same problem exists for Category Layout overrides but this patch does Not fix that. imho both problems should be fixed with one patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16755.

avatar mbabker
mbabker - comment - 30 Jun 2017

Are you talking about the feature this patch introduces in general or something with an already existing convention? If the latter, that is correctly a separate bug report and should be resolved with a separate patch independent of this.

avatar Webdongle
Webdongle - comment - 30 Jun 2017

@mbabker
I am now confused. Please look at #16926 ... is it part of the same issue or a separate issue ?

avatar mbabker
mbabker - comment - 30 Jun 2017

To be honest, that's not a part of the system I'm intimately familiar with. I see what this PR is adding on its own, but the rest of it is kind of over my head at the moment, especially when you start factoring in menu item configurations and parameter merging in the different scenarios.

avatar Webdongle
Webdongle - comment - 30 Jun 2017

@mbabker
Unless otherwise informed perhaps we should treat it as part of this issue ? This appears to be one of those issues that has more than one affect. Perhaps there is a common (underlying) root cause that needs to be addressed ?

avatar mbabker
mbabker - comment - 30 Jun 2017

Adding this field isn't going to fix the underlying issue. It might expose it in other ways, but to me it's separate just on what I'm reading.

avatar Webdongle
Webdongle - comment - 30 Jun 2017

Perhaps we should reopen the other tracker then ?

avatar mbabker
mbabker - comment - 30 Jun 2017

As long as it's clear what exactly each item is, then sure.

avatar coolcat-creations
coolcat-creations - comment - 8 Aug 2017

@Sieger66 @Webdongle @mbabker
Seems that the issue from Sieger66 is an expected behaviour and has nothing to do with this PR.
(After assigning a new template style to your menüitem, you have to apply the change to be able to select an override from that template) Please open a new issue if you want the Usability to be improved.

Can we set it RTC as we have two successful test?

avatar Sieger66
Sieger66 - comment - 12 Aug 2017

the issue from Sieger66 is an expected behaviour

I think this is not correct.

@coolcat-creations : please read my answer at
https://forum.joomla.de/index.php/Conversation/576-github/

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@coolcat-creations how to go on with that PR?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16755.

avatar coolcat-creations
coolcat-creations - comment - 26 Oct 2017

IMO the Bug that was Reported has nothing to do with this PR and could possibly be already fixed in this PR: #18061
Since we have successfull and unsuccessful tests, maybe someone can test again ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@Sieger66 or @Webdongle can you please retest?

avatar saraheagle
saraheagle - comment - 1 Nov 2017

@coolcat-creations, I will test this :)
I am learning how to do testing, reading these instructions https://docs.joomla.org/Testing_Joomla!_patches.
Please let me know if I should read any other documentation.

avatar Sieger66
Sieger66 - comment - 12 Nov 2017

I have retest this PR but the problem is the similar same problem as with #14802 that i have write in issue
#17912

avatar AndySDH
AndySDH - comment - 14 Nov 2017

Isn't this already implemented?

cattura

This sets the layout for Articles from a Category Blog menu item.

avatar Sieger66
Sieger66 - comment - 15 Nov 2017

Your picture is from the Article-Category-Blog-menuitem
PR 16755 make this in the Article Category List-menueitem

But, yes it is implemented with PR 14802 in the Options-Tab of the Article Category List-menuitem

https://github.com/joomla/joomla-cms/blob/3.8.2/components/com_content/views/category/tmpl/default.xml#L394-L401

PR 16755 do it in the List-Layouts-Tab of the Article Category List-menuitem and add a better description.

@coolcat-creations
If you want PR 16755
Delete in PR 16755 your changes from PR 14802 in the /components/com_content/views/category/tmpl/default.xml
or change only the descriptions in the files and delete your changes in PR 16755
in the /components/com_content/views/category/tmpl/default.xml

avatar AndySDH
AndySDH - comment - 15 Nov 2017

I think the position is correct because it relates to Article Options, and all article options are in the Options tab. No need to change position imho.

avatar coolcat-creations
coolcat-creations - comment - 19 Nov 2017

@Sieger66 Sorry I don't understand, what is the exact issue?

PR 16755 do it in the List-Layouts-Tab of the Article Category List-menuitem and add a better description.

@coolcat-creations
If you want PR 16755
Delete in PR 16755 your changes from PR 14802 in the /components/com_content/views/category/tmpl/default.xml
or change only the descriptions in the files and delete your changes in PR 16755
in the /components/com_content/views/category/tmpl/default.xml

avatar Sieger66
Sieger66 - comment - 19 Nov 2017

@coolcat-creations

with your PR 14802 comes in the Options-Tab of the Article-Category-List-menuitem already the
Choose a Layout.

Is no need to add with PR 16755 the same function in the
List-Layouts-Tab of the Article Category List-menuitem

avatar coolcat-creations
coolcat-creations - comment - 23 Nov 2017

Ah did not see this, this PR is actually from someone else I just moved the code, so let's close this then - right?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

@coolcat-creations give me a go for closing.

avatar coolcat-creations coolcat-creations - change - 23 Nov 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-11-23 15:15:54
Closed_By coolcat-creations
avatar coolcat-creations coolcat-creations - close - 23 Nov 2017
avatar coolcat-creations
coolcat-creations - comment - 23 Nov 2017

done ;)

Add a Comment

Login with GitHub to post a comment