? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
17 Jun 2017

Summary of Changes

This just add another class to the toolbar buttons.

Testing Instructions

apply the patch
got to the backend list views
inspect a toolbar button (like checkin)
confirm you now find button-checkin (or similiar)
image

Expected result

button-$name

Actual result

none

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 17 Jun 2017
avatar zero-24 zero-24 - change - 17 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2017
Category Libraries
avatar zero-24 zero-24 - change - 17 Jun 2017
The description was changed
avatar zero-24 zero-24 - edited - 17 Jun 2017
avatar yvesh yvesh - test_item - 17 Jun 2017 - Tested successfully
avatar yvesh
yvesh - comment - 17 Jun 2017

I have tested this item successfully on 49aa04a

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16737.

avatar SniperSister SniperSister - test_item - 17 Jun 2017 - Tested successfully
avatar SniperSister
SniperSister - comment - 17 Jun 2017

I have tested this item successfully on 49aa04a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16737.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 17 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jun 2017

I have tested this item successfully on 49aa04a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16737.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jun 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jun 2017

RTC after two successful tests.

avatar zero-24 zero-24 - change - 17 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jun 2017
Category Libraries Libraries Unit Tests
avatar zero-24 zero-24 - change - 17 Jun 2017
Status Ready to Commit Pending
Labels Added: ?
Removed: ?
avatar zero-24
zero-24 - comment - 17 Jun 2017

Travis is happy now too.

avatar rdeutz rdeutz - change - 17 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-17 12:00:45
Closed_By rdeutz
avatar rdeutz rdeutz - close - 17 Jun 2017
avatar rdeutz rdeutz - merge - 17 Jun 2017

Add a Comment

Login with GitHub to post a comment