[#16736] - Remove administrator helper test
- Closed
- 5 Jan 2018
- Medium
- Build: staging
- # 16736
- Diff
- rdeutz:remove_administratortest
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Cleaning up our tests. Remove last administrator test. Test was for a static helper function. Should be better tested with an system test because it can't be unit tested
Testing Instructions
Check if the unit test still running
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
Ya I'm kinda with George here. Sure the class is a static helper, but at least its dependencies are mockable through an absurd series of events (good ol' JFactory).
Once we switch over to the newer test structure then I'd hit the button, but for now this just seems like deleting a test for the sake of it.
no keep it open, I need to be in good mood to write an answer here :-)
You are rteired now - you should be in a permanent good mood
not really but we can close it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-05 06:08:12 |
| Closed_By | ⇒ | rdeutz |
Why can't this be unit tested? The unit tests look fine to me?