[#16733] - Enforce array for subform values
- Fixed in Code Base
- 6 Aug 2017
- Medium
- Build: staging
- # 16733
- Diff
- bembelimen:patch-28
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR enforce, that the value is an array, because I had the case, that I get an object and the field stopped working.
Testing Instructions
Apply the patch, it should work like before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Now the values save correctly and are also shown in the subform field
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16733.
Did you get here an object produced in core or by an extension? Because there should never arrive here an object if all is working as it should. If there is code in core which passes an object, then the bug is probably on that edge.
Yes the list based custom fields.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16733.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16733.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
zero-24
- | Milestone |
Added: |
||
I just fear that it can have unexpected behaviors if an object is passed. @bembelimen where and how do you pass the object, perhaps I do miss something here.
rdeutz
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
@bembelimen any feedback on Allon's last comment?
I'm not sure, what I should answer here?
If the data is an object, you'll get an error.
The object is passed via $form->bind($data);
The question is: what should break here, because the field expect an array...
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-06 16:20:14 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on fb04de3
Now the values save correctly and are also shown in the subform field
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16733.