PR: #16693

Reopening since that PR didn't help at all.

Really? It fixed the console error for me in IE11

Still exact same error message, only a few lines later due to the added lines from your PR.

Tested on currrent 4.0-dev branch (commit afa4756)

@Bakual can you translate the error message please?

The object doesn't support the property or method "closest"

The difference to the first test is that this is now on a Windows 10 computer (at home) while the other was a Windows 7 (at work). But I guess that shouldn't matter.

It shouldn't make a difference at all as I believe the IE version are exactly the same....just with a different version number (11 - 12)

It's always IE 11. There is no IE12 ?

That was the beer talking lol

The PR has unfortunately been merged (without tests) so could you test 1 more time and let me know if you still get an error from the template.js?

You also mentioned an error in the list views....just FYI, that PR wasn't supposed to fix that....only the sidebar ;)

You also mentioned an error in the list views....just FYI, that PR wasn't supposed to fix that....only the sidebar ;)

Yeah, got that. Another reason why the issue shouldn't have been closed ?

The PR has unfortunately been merged (without tests) so could you test 1 more time and let me know if you still get an error from the template.js?

Not sure what to test. My test was done with the merged PR already and that PR didn't get any changes after the merge to my knowledge. Or did I miss something?

I'm assuming you've ensured it's not browser cache or something stupid

Hmm odd, cause before the PR, I was getting a console log error regarding closest(), which prevented the sidebar from working at all. After the PR, it was all good.

@ciar4n could you test on IE11 please and see if you get any errors?

I'm assuming you've ensured it's not browser cache or something stupid

I verified in the browser dev tools that the JS files got the changes in it. As you can see from the screenshot, there is also a difference in the linenumbers where the error occurs, the difference is exactly by the lines added by the PR. So I doubt it is browser caching, would be very odd then.

Getting the same error...

Object doesn't support property or method 'closest'

This not the reason for?.. https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/js/template.js#L17

That's just the function for this: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/js/template.js#L137

Supposed to be like jQuery's closest() function

In that case https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/js/template.js#L137 this line should be var firstLevel = closest(allLinks[i], '.collapse-level-1'); rather than the current line?

@Bakual - could you try the above and see if you still get the same error?

The change suggested by @wilsonge seems to fix the first error indeed.

PR: #17029

closed as having PR.

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/16688