[#16662] - Improve exception message in JForm::getInstance
- Fixed in Code Base
- 21 Jun 2017
- Medium
- Build: staging
- # 16662
- Diff
- chrisdavenport:patch-5
User tests: Successful: Unsuccessful:
Summary of Changes
Currently the exception message for an invalid second argument in JForm::getInstance is not very helpful because it doesn't provide the name of the form that caused the exception. This PR replaces the unhelpful "name" with the actual name of the form in the exception message.
Testing Instructions
Write the following line of code somewhere convenient (eg. your template):
JForm::getInstance('myform', '');
Before applying this PR the exception message will be
JForm::getInstance(name, *string*)
After applying this PR the exception message will be
JForm::getInstance(myform, *string*)
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Could reproduce issue successfully
Applied patch with expected result
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16662.
I have tested this item
Reproduced the problem as stated and got the expected message after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16662.
I have tested this item
Added JForm::getInstance('myform', ''); in Index.php
Reproduced error as described.
Applied patch
Issue solved as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16662.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 18:31:08 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Hope it ends out better than #13050?