[#16661] - Ignore the "Show Options" setting for the custom fields
- Fixed in Code Base
- 21 Jun 2017
- Medium
- Build: staging
- # 16661
- Diff
- Digital-Peak:cf/ignore-options
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15473.
Summary of Changes
If the "Show Article Options" flag is set to no, then the custom fields are hidden as well. More infroamtion can be found in the issue #15473.
This pr changes the logic to only hide the "Options" tab when editing an article, the custom fields will still be displayed. This means that only fieldsets with the name basic are not displayed anymore with this pr, every other will still. So there is NO configuration setting to hide all additional fieldsets like before the patch.
Additionally the code got a bit of inline documentation as it starts to become more and more complex.
Testing Instructions
- Create a custom field for articles
- In the article options set the "Show Article Options" flag to NO
- Edit an article
Expected result
Only the Options tab is hidden. The Fields tab is displayed.
Actual result
The Fields tab is hidden.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16661.
I have tested this item
could reproduce issue on clean install.
Patch applied and custom fields displayed again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16661.
I have tested this item
Created custom field
Reproduced error
Applied patch
Problem solved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16661.
I have tested this item
I have tested this item succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16661.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 18:30:06 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Imho, that "showOptions" parameter is a strange one anyway and should be moved away from the JLayout. Instead we should set the hiddenFieldsets and/or ignoreFieldsets in the view based on the state of that parameter. That would make more sense to me and should actually simplify the code.
Since we change the behavior of this JLayout quite a bit already, it could be worth thinking a bit more about how we want it. Especially for J4.