Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#16609] - [4.0] Impossible to create new Menu Type

? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Jun 2017

Try creating a new Menu (Menu type)
Error is Class 'Joomla\CMS\Table\JApplicationHelper' not found

Patch and retest

avatar infograf768 infograf768 - open - 10 Jun 2017
avatar infograf768 infograf768 - change - 10 Jun 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jun 2017
Category ⇒ Libraries
avatar joomdonation
joomdonation - comment - 10 Jun 2017

It would be better if we can use the class directly instead of an aliased class. So;

  1. Add an use statement at the top (after defined line)
defined('JPATH_PLATFORM') or die;

use Joomla\CMS\Application\ApplicationHelper;

Then change the line you changed to just;

$this->menutype = ApplicationHelper::stringURLSafe($this->menutype);
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Jun 2017

I have tested this item ✅ successfully on 8dbe258

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16609.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 Jun 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 10 Jun 2017

@joomdonation

The issue is also present in other files.
I found by Grep quite a few places where we have
JApplicationHelper::

and no alias or direct class.
It may be a good idea to solve all together and I would close this.

avatar joomdonation
joomdonation - comment - 10 Jun 2017

@infograf768 I made PR #16615 as requested

avatar wilsonge wilsonge - change - 11 Jun 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-06-11 11:56:41
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 11 Jun 2017

Add a Comment

Login with GitHub to post a comment