[#16608] - [4.0] Fix articles modules
- Fixed in Code Base
- 14 Jun 2017
- Medium
- Build: 4.0-dev
- # 16608
- Diff
- joomdonation:fix_articles_modules
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Similar to #16607, this PR fixes the remaining modules:
- mod_articles_category
- mod_articles_news
- mod_articles_popular
It including calling the namespaced class from com_content + use the namespaced class instead some aliases class
Testing Instructions
Code review. Maybe @wilsonge can review and merge it
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
It is actually not related to this PR. It causes by Content - Page Break plugin https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/content/pagebreak/pagebreak.php#L81
I haven't read the code of that plugin yet, so we can leave it to next PR
| Labels |
Added:
?
|
||
OK. So I checked and found that the issue happens with Joomla 3.x as well, so look like a bug from this module
I checked article view, and see that the fourth parameter of onContentPrepare trigger has null as default value. So I changed the parameter value from 1 to 0 on this commit 2005578. @wilsonge Please check it to confirm the change is correct.
@franz-wohlkoenig Please test it again
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16608.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-14 16:09:45 |
| Closed_By | ⇒ | wilsonge |
I have tested this item? unsuccessfully on 63d2a98
index.php/news-flash give 404.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16608.