? Failure

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
7 Jun 2017

Pull Request for Issue # .

Summary of Changes

Fixes for the latest sync with 3.x

Testing Instructions

  • Code review

screen shot 2017-06-07 at 16 52 51

Expected result

Actual result

Documentation Changes Required

avatar dgt41 dgt41 - open - 7 Jun 2017
avatar dgt41 dgt41 - change - 7 Jun 2017
Status New Pending
avatar dgt41
dgt41 - comment - 7 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jun 2017
Category JavaScript Repository Libraries
avatar dgt41 dgt41 - change - 7 Jun 2017
Labels Added: ?
avatar dgt41 dgt41 - change - 7 Jun 2017
The description was changed
avatar dgt41 dgt41 - edited - 7 Jun 2017
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar brianteeman brianteeman - change - 8 Jun 2017
Milestone Added:
avatar wilsonge
wilsonge - comment - 8 Jun 2017

Whats this PR doing? I have absolutely no clue :)

avatar dgt41
dgt41 - comment - 8 Jun 2017
  • gets the Xpath polyfill with grunt
  • removes the -uncompressed.js
  • sorts the tab-state.js/tab-state.min.js (the first had the minified version)
avatar Bakual
Bakual - comment - 8 Jun 2017

@wilsonge Looks like he fixes your wrong merge conflict fixing ?

avatar dgt41
dgt41 - comment - 8 Jun 2017

And a fix to jquery.simplecolors.min.js which we renamed some time ago to simplecolors.min.js (due to wrong file handling of filenames with multiple .)

avatar wilsonge
wilsonge - comment - 3 Jul 2017

Conflicts

avatar dgt41
dgt41 - comment - 3 Jul 2017

@wilsonge fixed

avatar wilsonge wilsonge - change - 3 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-03 13:45:07
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Jul 2017
avatar wilsonge wilsonge - merge - 3 Jul 2017

Add a Comment

Login with GitHub to post a comment