? ? ? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
3 Jun 2017

Pull Request for Issue #15187 .

Summary of Changes

The pull fix the way how the script calculate the id for a fields and it's labels.
Also now it should be more close to JFormField::getId result.

Testing Instructions

For test can use next XML (place it in some params form,eg in template or custom module):

<field type="subform" name="subform" label="Subform" multiple="true">
    <form>
        <field type="radio" name="radio1" label="Radio">
            <option value="1">Val 1</option>
            <option value="2">Val 2</option>
        </field>
        <field type="checkboxes" name="checkboxes1" label="checkboxes">
            <option value="3">Val 3</option>
            <option value="4">Val 4</option>
        </field>
        <field type="checkbox" name="checkbox1" label="checkbox" value="1"/>
        <field type="text" name="text1" label="text1"/>
    </form>
</field>

Expected result

After add "new row", check the input/labels id, they should be similar to screenshot:
screen 2017-06-03 17 18 02 936x245

Actual result

ID of the labels is not fixed,
they contain X eg: ..._subform__subformX_..

screen 2017-06-03 17 42 41 904x243

Documentation Changes Required

none

avatar Fedik Fedik - open - 3 Jun 2017
avatar Fedik Fedik - change - 3 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2017
Category JavaScript
avatar Fedik Fedik - change - 3 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2017
Category JavaScript JavaScript Unit Tests
avatar degobbis degobbis - test_item - 11 Oct 2017 - Tested successfully
avatar degobbis
degobbis - comment - 11 Oct 2017

I have tested this item successfully on bf44558
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16480.

avatar drmenzelit drmenzelit - test_item - 12 Oct 2017 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 12 Oct 2017

I have tested this item successfully on bf44558


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16480.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 15 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-15 15:57:49
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 15 Oct 2017
avatar mbabker mbabker - merge - 15 Oct 2017

Add a Comment

Login with GitHub to post a comment