[#16471] - Fix for: Repeatable field is no longer rendered with Chosen layout
- Fixed in Code Base
- 25 Jul 2017
- Medium
- Build: staging
- # 16471
- Diff
- Fedik:fix-chosen-repetable
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16110
Summary of Changes
The patch rerender Chosen.js if it was there before
Testing Instructions
please see #16110 and #14556 for detail
Example xml which can be used for test:
<field name="repeatable" type="repeatable" icon="list" label="Repeatable" select="select">
<fieldset hidden="true" name="repeatable_modal" repeat="true">
<field type="list" name="list1" label="List1">
<option>- Select -</option>
<option value="val1">val 1</option>
<option value="val2">val 2</option>
<option value="val3">val 3</option>
</field>
<field type="list" name="list2" label="List2" multiple="true">
<option>- Select -</option>
<option value="val4">val 4</option>
<option value="val5">val 5</option>
<option value="val6">val 6</option>
<option value="val7">val 7</option>
<option value="val8">val 8</option>
</field>
</fieldset>
</field>
Expected result
Chosen.js rendered
Actual result
Only default <selec> list
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
The dropdown was a regular select before the patch but after applying the patch it is now a chosen dropdown.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16471.
sorry I missed this, for some reason git is not emailing me with notices.. I'll get this tested in next 72hrs
sorry guys, idk why but github refuses to send me notification for joomla. I get them for neard but not from joomla. I keep forgetting to get this done.. I"m going to leave the tab open so I don't forget.. give me 30 min.
I have tested this item
This worked very nicely. RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16471.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-25 23:43:49 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
@N6REJ please test also