? ? Failure

User tests: Successful: Unsuccessful:

avatar fastslack
fastslack
2 Jun 2017

Namespace Http classes

Test instructions

After apply this patch, Joomla! should work as usually

avatar fastslack fastslack - open - 2 Jun 2017
avatar fastslack fastslack - change - 2 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2017
Category Libraries
avatar fastslack fastslack - change - 3 Jun 2017
Labels Added: ?
avatar mbabker
mbabker - comment - 3 Jun 2017

@wilsonge This one could pose a problem, from Travis:

1) JHttpFactoryTest::testGetHttpTransports
CURL should be the first transport returned.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'curl'
+'CurlTransport'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/joomla/http/JHttpFactoryTest.php:81
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jun 2017
Category Libraries Libraries Unit Tests
avatar fastslack fastslack - change - 22 Jun 2017
Title
Namespace Http classes
[3.8] Namespace Http classes
avatar fastslack fastslack - edited - 22 Jun 2017
2422cfe 22 Jun 2017 avatar fastslack Ups
avatar laoneo
laoneo - comment - 1 Jul 2017

Just stumbled over https://github.com/joomla-framework/http. Should we not try to integrate that package similar to what we did with the archive package in #14157?

avatar mbabker
mbabker - comment - 1 Jul 2017

No. The internals of the transports are handled differently (the CMS' fully reads from JFactory::getConfig() whereas the Framework's requires everything to be injected). The 4.0 branch extends the Framework package to the extent possible, but to me that's as far as we can go with it right now until we make the CMS' HttpFactory read and inject all the right parameters. And that becomes a hard B/C break because it forces everyone to go through the factory to get a properly configured adapter whereas right now it can be done just by calling new JHttp.

avatar mbabker mbabker - change - 7 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-07 12:51:11
Closed_By mbabker
avatar mbabker mbabker - close - 7 Jul 2017
avatar mbabker mbabker - merge - 7 Jul 2017
avatar laoneo
laoneo - comment - 7 Jul 2017

Thanks!

Add a Comment

Login with GitHub to post a comment