?
avatar Supun94
Supun94
1 Jun 2017

I'm trying to do migrating part from jQuery to Vanilla Javascript in tabs-state.js file. Since there're are many Bootstrap 4 tabs scripts[1] I want to know we will keep the bootstrap 4 tab scripts or not in Joomla 4 ?

[1] https://github.com/Supun94/gsoc17_js_tests/blob/master/media/system/js/tabs-state.js#L31

avatar Supun94 Supun94 - open - 1 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 1 Jun 2017
avatar Supun94
Supun94 - comment - 1 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jun 2017
Title
[4.0] Keep the Bootstrap 4 tab scripts
[4.0] Keep the Bootstrap 4 tab scripts
avatar joomla-cms-bot joomla-cms-bot - edited - 1 Jun 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jun 2017
Category JavaScript
avatar dgt41
dgt41 - comment - 1 Jun 2017

@Supun94 the tab_state.js will be nice to be vanilla.
The aim for the UI elements for Joomla 4 is to use custom elements (some preliminary work can be found here: https://github.com/dgt41/bs4-custom-elements

So at the moment you can convert all the parts to vanilla but the actual call to modal open will need to stay as jQuery.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Jun 2017
Status New Discussion
avatar PhilETaylor
PhilETaylor - comment - 3 Jun 2017

Tab state js has been almost completely re-written and merged in staging

The version at https://github.com/Supun94/gsoc17_js_tests/blob/master/media/system/js/tabs-state.js is hugely out of date!!!

To preserve the hours of input I made into the issues - please ensure you use the right JS file!

avatar brianteeman brianteeman - change - 18 Aug 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-08-18 17:10:25
Closed_By brianteeman
avatar brianteeman brianteeman - close - 18 Aug 2017

Add a Comment

Login with GitHub to post a comment