[#16367] - [3.8] Namespace document
- Closed
- 28 Jul 2017
- Medium
- Build: 3.8-dev
- # 16367
- Diff
- fastslack:namespace-document
- Success hound No violations found. Woof! Details
- Success continuous-integration/jenkins/pr-merge This commit looks good Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Namespace for document classes
Summary of Changes
Move /libraries/joomla/document to /libraries/src/Joomla/CMS/Document
Testing Instructions
Apply patch and try to create one article
Expected result
No errors
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
@mbabker I removed that files because are duplicated and are not needed any more. Look at the files, there is only mapping to deprecated files.
We can solve compatibilities issues in classmap.php file.
https://github.com/fastslack/joomla-cms/blob/namespace-document/libraries/classmap.php#L191
Maybe we should remove that tests
| Labels |
Added:
?
|
||
We don't need the format in the short class section for the renderers. So for example instead of Joomla\CMS\Document\Renderer\Html\RendererHtmlComponent we can do something like Joomla\CMS\Document\Renderer\Html\ComponentRenderer.
OK, one more pedantic change, then there's one concern we need to quickly look over. For the document classes, can you change it to <format>Document instead of Document<format>?
The concern - we have some files here that have multiple classes in them. I think this would be a good time to move them out to separate files.
Thanks!
Fixed the items I pointed out and merged to staging.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-28 12:33:58 |
| Closed_By | ⇒ | mbabker |
This has test issues.