Trash or archive an article
Trashed and archived articles don't show in the list expect when search filter is set to show them.
All articles show.
After clearing the search filters with the button, the list filters as expected until you log out and in again.
Labels |
Added:
?
|
this is the same as in J3
Can't reproduce it in current staging. By default, trashed and archived articles aren't shown in the manager. You need to either filter by that state or set it to "All"
I'm talking about the admin manager list, just in case you were looking somewhere else (I wasn't clear in the issue).
now i am very confused what you are talking about
ah - now I understand what you are saying
These are my findings (tested on sample data of 4.0-dev branch on PHP 5.6.24):
login to administration, go to article manager, you see a list of articles.
Check an article, click on Trash button in toolbar. After page refresh, article will stay on the list, same goes for Archived articles.
Till now expected behavior was that after that trashed/archived article was no longer visible on the list of articles.
If you use filters in Search tools, for example to filter trashed articles only and after that select -Select status- in dropdown and reset filter, you will get a list without trashed/archived articles.
If you have trashed/archived articles from before, they will be visible when you visit Article manager.
Status | New | ⇒ | Discussion |
Category | ⇒ | com_content |
This issue is related to the change in my PR #15455
Now, the first time you visit the page, the $published value has value null instead of '' (empty string) like before. There are different ways to fix it:
$published = (string) $this->getState('filter.published');
$this->setState('filter.published', '');
Do you think which one is best @Bakual?
I came to same conclusion (null vs '') but couldn't figure out which PR was responsible
My solution would be to just loosen the comparision like this elseif ($published == '')
, but casting to string would work as well. I wouldn't add something to the populateState method thought.
Closing as we have a PR
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-31 13:23:24 |
Closed_By | ⇒ | Bakual |
this is the same as in J3