[#16345] - [4.0] Fields and Field Groups remove div
- Closed
- 9 Jun 2017
- Medium
- Build: 4.0-dev
- # 16345
- Diff
- brianteeman:fields_div
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Success continuous-integration/drone/push the build was successful Details
- Error continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
There was an extra div above the search bar in these two views which resulted in a broken layout - see the before and after screenshots
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@fastslack can you please select an successfully test at https://issues.joomla.org/tracker/joomla-cms – thanks. For this PR i have altered your Test.
Is the context switcher in Content -> Fields still displayed?
how come there are 6 automated tests instead of 3?
@laoneo ah - so thats what this div was for. so this PR is wrong in being removed and the issue is that when there is no context switcher the div is not hidden
@C-Lodder its because I did a branch here first instead of just a branch on my fork
I need to redo this PR so that the div is only hidden if there is no context switcher
@franz-wohlkoenig please remove the RTC as this PR is not correct
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
RTC removed.
I am closing this as there is no longer any need for it as it was resolved differently elsewhere
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-09 17:24:54 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on 0bcc953
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16345.