? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
29 May 2017

Summary of Changes

  • Fix variable with double dollar sign
  • Remove references to polyfills that got merged from staging
  • Remove references to Mootools
  • Improvements to com_finder results page
avatar C-Lodder C-Lodder - open - 29 May 2017
avatar C-Lodder C-Lodder - change - 29 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 May 2017
Category Administration com_contact com_content com_finder com_media com_menus com_modules com_users Language & Strings Front End Layout Libraries JavaScript Plugins Templates (site)
avatar C-Lodder C-Lodder - change - 29 May 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 29 May 2017

I have tested this item ? unsuccessfully on e67273a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16324.

avatar brianteeman brianteeman - test_item - 29 May 2017 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 29 May 2017

Really not sure why you made this change - plus it looks bad

screenshotr14-48-52

avatar C-Lodder
C-Lodder - comment - 29 May 2017

@brianteeman - if there were some errors, please try again now as conflicts are solved.

I moved the "How to search" to a popover as it was some long winded paragraph and on smaller viewports, like the one I'm using, I was having to scroll down to access the select boxes.

avatar brianteeman
brianteeman - comment - 29 May 2017

but now you have made a popover that is unusable on a mobile device and it was an optional setting before whereas now it is always present

avatar brianteeman
brianteeman - comment - 29 May 2017

Also I am now getting
The file marked for modification does not exist: administrator/components/com_contact/tmpl/contacts/modal.php

as a result of #16319

avatar C-Lodder
C-Lodder - comment - 29 May 2017

@brianteeman - Reworked the results page a little. Added parameter back in and displayed the content as a outlined card.

avatar brianteeman
brianteeman - comment - 29 May 2017

Still cant apply #16324 (comment)

avatar C-Lodder
C-Lodder - comment - 29 May 2017

No idea. Must have been something to do with: #16319

Perhaps try re-fetching the PR's with com_patchtester and then applying it.....or try manually fetching the PR via command line using:

$ git fetch upstream pull/16324/head:moo2
$ git checkout moo2
avatar brianteeman
brianteeman - comment - 29 May 2017

Please check all the options. For example expand advanced search no longer has any effect

avatar brianteeman
brianteeman - comment - 29 May 2017

Also with this PR applied I have lost the green on the toggles and the muted text
screenshotr15-52-13
screenshotr15-52-37

avatar C-Lodder
C-Lodder - comment - 29 May 2017

@brianteeman - fixed switcher labels and auto expand advanced search

avatar brianteeman
brianteeman - comment - 29 May 2017

I have tested this item successfully on 327326b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16324.

avatar brianteeman brianteeman - test_item - 29 May 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 29 May 2017

Thanks Brian

avatar wilsonge wilsonge - change - 30 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-30 09:32:47
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 May 2017
avatar wilsonge wilsonge - merge - 30 May 2017

Add a Comment

Login with GitHub to post a comment