? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 May 2017

continue the removal of closing slashes for tags that do not require this in html5

hr
meta
link
br

Please note this PR does not include "required?" changes to the system language code plugin as I am not 100% sure I understand the regex there. - that can be done either as a new PR or as a pull request against this one.

@wilsonge @C-Lodder this is a redo of #15877

avatar brianteeman brianteeman - open - 26 May 2017
avatar brianteeman brianteeman - change - 26 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2017
Category Administration com_content Templates (admin) Front End Installation Layout External Library Libraries JavaScript Plugins Templates (site) Unit Tests
avatar dgt41
dgt41 - comment - 26 May 2017

@brianteeman may I suggest another change?
Instead of using a very generic HR tag with an id <hr id="system-readmore">
we can have something more specific for the task, e.g. <joomla-article-readmore></joomla-article-redmore>

avatar brianteeman
brianteeman - comment - 26 May 2017

@dgt41 that is beyond the scope of this PR and potentially introduces an unneeded bc issue

avatar brianteeman brianteeman - change - 26 May 2017
Labels Added: ? ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 May 2017
Category Administration com_content Templates (admin) Front End Installation Layout External Library Libraries JavaScript Plugins Templates (site) Unit Tests Administration com_content Templates (admin) Front End Installation Layout External Library Libraries JavaScript Plugins Templates (site)
avatar wilsonge wilsonge - change - 26 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-26 09:19:44
Closed_By wilsonge
Labels Removed: ?
avatar wilsonge wilsonge - close - 26 May 2017
avatar wilsonge wilsonge - merge - 26 May 2017
avatar wilsonge
wilsonge - comment - 26 May 2017

Awesome - thanks!

avatar brianteeman
brianteeman - comment - 26 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment