User tests: Successful: Unsuccessful:
Namespace grid. Who the heck is still using this class?
After the discussion in this pr, the JGrid
class will be deprecated.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
So we deprecate it in 3 and remove it in 4?
NO! you cannot delete this from j3!
as there is no moo tools to support the js part of this
This class is an HTML table generator, where's the JS support?
FALSE Alarm: I thought we were talking about https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/cms/html/jgrid.php
@brianteeman That's JHtmlGrid
, different from JGrid
.
And JHtmlJgrid
(also, why the hell do we have 3 grid classes!?)
Grid is important!
That's why that pr took me so long as I had to find the correct one
I guess that class is nowehere used in core. Should we deprecate it and remove it in 4. Who the hell is doing nowadays a grid with a table?
The admin list views are table based grids.
Who the hell is doing nowadays a grid with a table?
Actually a grid class could be very handy if combined with modern tech, e.g. web components: https://www.webcomponents.org/search/grid
But this class is not used in core. So I suggest to deprecate it and remove it. Guess nobody is doing a HTML table in the admin with this class or will do a web component with it.
Isn't Hathor using it?
@brianteeman we're in J4 mode here
I didn't see any reference to it in PHPStorm.
This was something Hannes did for 1.6. It does have some use cases if you want to build plugin events to add columns dynamically to list views in the backend. But we aren't using it in core. It's on my list of items to discuss over the next day or two
No I never got there. I think it can be removed (i mean i know for sure it's not being used - it's just if we actually want to consider it being used or not)
So I'm oing to deprecate it in 3 and remove it in 4, similar to the less lib?
That seems fair to me.
Labels |
Added:
?
|
Title |
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-03 14:04:41 |
Closed_By | ⇒ | mbabker |
I wrote that class several years ago with the intent of being able to make the core components extendable. The idea was to fill the objects with the respective data and in the layout files to simply do the output. Between filling the object in JView::display() and getting the actual output, a plugin event could have been used to then let plugins modify the tables. For example a search plugin could add a column to display if the content was properly indexed or not, etc.
I wrote the class, explained it exactly as I did here, rewrote a bunch of core components and the PR for JGrid was accepted. When I then proposed the PR to rewrite the core components, I was told that our users are to stupid to understand this and thus this would not be used. Several weeks of work for the dumpster. Nice.
Reminds me of the router. And the MVC classes. And lots of other stuff in this project.
@laoneo actually you need to delete this file, as there is no moo tools to support the js part of this