Pull Request for Issue pull request #16197 re-do to allow tests to pass.
Darnit, and I thought me and Travis were friends.
Category | ⇒ | com_menus Router / SEF |
Status | New | ⇒ | Discussion |
Then what?
Some else should make the PR
OK, will do
Seriously? So the answer is I can't make PR's at all so lets not bother sorting. Now I know I shouldn't have bothered.
We need to have PR where our test are running, figure out what happened with you and travis or do you thing we should look into it?
@tonypartridge maybe its just an issue on this one. Please create a new pr for anything at all (we can delete it after testing) so we can test if it was a one off. If that PR gets blocked as well then we can look further into it to make sure that you are unblocked. It is not acceptable for you to be blocked completely on travis and I dont think anyone was thinking that would be.
Closed as Travis said no.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 08:19:09 |
Closed_By | ⇒ | tonypartridge |
Category | com_menus Router / SEF | ⇒ | Libraries Router / SEF |
We have one Travis error
1) JComponentRouterRulesMenuTest::testPreprocessLanguage
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 'Itemid' => '47'
)
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/component/router/rules/JComponentRouterRulesMenuTest.php:218
thats the same travis error that the original PR had that was reverted iirc
yes it is, now we need to find out if the test is not good or do we have to change the code
and on that note i will step back
According to Travis...
The webhooks to the issue tracker failed too.