avatar tonypartridge
tonypartridge
23 May 2017

Pull Request for Issue pull request #16197 re-do to allow tests to pass.

avatar tonypartridge tonypartridge - open - 23 May 2017
avatar mbabker
mbabker - comment - 23 May 2017

According to Travis...

abuse detected: known offender (request looked fishy)

The webhooks to the issue tracker failed too.

avatar tonypartridge
tonypartridge - comment - 23 May 2017

Darnit, and I thought me and Travis were friends.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 May 2017
Category com_menus Router / SEF
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 May 2017
Status New Discussion
avatar infograf768
infograf768 - comment - 24 May 2017

Then what?

avatar rdeutz
rdeutz - comment - 24 May 2017

Some else should make the PR

avatar infograf768
infograf768 - comment - 24 May 2017

OK, will do

avatar tonypartridge
tonypartridge - comment - 24 May 2017

Seriously? So the answer is I can't make PR's at all so lets not bother sorting. Now I know I shouldn't have bothered.

avatar rdeutz
rdeutz - comment - 24 May 2017

We need to have PR where our test are running, figure out what happened with you and travis or do you thing we should look into it?

avatar brianteeman
brianteeman - comment - 24 May 2017

@tonypartridge maybe its just an issue on this one. Please create a new pr for anything at all (we can delete it after testing) so we can test if it was a one off. If that PR gets blocked as well then we can look further into it to make sure that you are unblocked. It is not acceptable for you to be blocked completely on travis and I dont think anyone was thinking that would be.

avatar tonypartridge
tonypartridge - comment - 24 May 2017

Closed as Travis said no.

avatar tonypartridge tonypartridge - close - 24 May 2017
avatar tonypartridge tonypartridge - change - 24 May 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-05-24 08:19:09
Closed_By tonypartridge
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2017
Category com_menus Router / SEF Libraries Router / SEF
avatar infograf768
infograf768 - comment - 24 May 2017

Posted your PR here
#16233

and crossing fingers I am not also expelled by Travis ?

avatar infograf768
infograf768 - comment - 24 May 2017

We have one Travis error

1) JComponentRouterRulesMenuTest::testPreprocessLanguage

Failed asserting that two arrays are equal.

--- Expected

+++ Actual

@@ @@

 Array (

-    'Itemid' => '47'

 )

/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/component/router/rules/JComponentRouterRulesMenuTest.php:218

avatar brianteeman
brianteeman - comment - 24 May 2017

thats the same travis error that the original PR had that was reverted iirc

avatar rdeutz
rdeutz - comment - 24 May 2017

yes it is, now we need to find out if the test is not good or do we have to change the code

avatar brianteeman
brianteeman - comment - 24 May 2017

and on that note i will step back

Add a Comment

Login with GitHub to post a comment