[#16178] - [Associations] Correcting Copy Reference to Target issue
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 16178
- Diff
- infograf768:multiassoc_copy
User tests: Successful: Unsuccessful:
Pull Request for Issue #16168
Summary of Changes
src is used elsewhere in the js.
Therefore the error was to use data-url
Testing Instructions
Patch. Clear all caches.
After Patch
All should be fine.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16178.
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 08:21:38 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
No i didnt as I couldnt replicate that before
I did not get any race condition anymore ( You are not permitted, etc.)
@PhilETaylor you can still have your code back here with a little more code, e.g. have a container div with all the attributes the iframe needs and then create the iframe element in runtime. That will cover the race conditions, I guess
If a variable is changed —in this case the variable src was changed to data-url in the edit form, then it should have been changed all over the js when the target is loaded. That was not the case and it indeed broke the target reload.
The copy to reference is a huge crap load of functions, it first saves the article in the left pane, then loads an article in the left pane, then decides its the wrong language and so loads the initial language in the left pane, and then finally loads the right pane....
The whole component is badly written - because it tried to reuse existing core features (like tmpl=component)...
So if this fixes the race and fixes the copy then excellent...
I hope someone will improve all this in 4.0
I have tested this item✅ successfully on 788f99c
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16178.