? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 May 2017

Pull Request for Issue #16168

Summary of Changes

src is used elsewhere in the js.
Therefore the error was to use data-url

Testing Instructions

Patch. Clear all caches.

After Patch

All should be fine.

multiassoc_copy

@appnweb @brianteeman @PhilETaylor @AlexRed @alikon

avatar infograf768 infograf768 - open - 22 May 2017
avatar infograf768 infograf768 - change - 22 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2017
Category Administration com_associations JavaScript
avatar AlexRed
AlexRed - comment - 22 May 2017

I have tested this item βœ… successfully on 788f99c

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16178.

avatar AlexRed AlexRed - test_item - 22 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 May 2017

I have tested this item βœ… successfully on 788f99c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16178.

avatar brianteeman brianteeman - test_item - 22 May 2017 - Tested successfully
avatar rdeutz rdeutz - change - 22 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 08:21:38
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017
avatar PhilETaylor PhilETaylor - comment - 22 May 2017
avatar brianteeman
brianteeman - comment - 22 May 2017

No i didnt as I couldnt replicate that before

avatar infograf768
infograf768 - comment - 22 May 2017

I did not get any race condition anymore ( You are not permitted, etc.)

avatar dgt41
dgt41 - comment - 22 May 2017

@PhilETaylor you can still have your code back here with a little more code, e.g. have a container div with all the attributes the iframe needs and then create the iframe element in runtime. That will cover the race conditions, I guess

avatar infograf768
infograf768 - comment - 22 May 2017

If a variable is changed β€”in this case the variable src was changed to data-url in the edit form, then it should have been changed all over the js when the target is loaded. That was not the case and it indeed broke the target reload.

avatar PhilETaylor PhilETaylor - comment - 22 May 2017
avatar PhilETaylor
PhilETaylor - comment - 22 May 2017

The copy to reference is a huge crap load of functions, it first saves the article in the left pane, then loads an article in the left pane, then decides its the wrong language and so loads the initial language in the left pane, and then finally loads the right pane....

The whole component is badly written - because it tried to reuse existing core features (like tmpl=component)...

So if this fixes the race and fixes the copy then excellent...

avatar infograf768
infograf768 - comment - 22 May 2017

I hope someone will improve all this in 4.0 😺

Add a Comment

Login with GitHub to post a comment